Status bar & Tablist fullscreen settings option#1126
Open
fictitiousexistence wants to merge 2 commits intoluakit:developfrom
Open
Status bar & Tablist fullscreen settings option#1126fictitiousexistence wants to merge 2 commits intoluakit:developfrom
fictitiousexistence wants to merge 2 commits intoluakit:developfrom
Conversation
Add `status_bar.fullscreen_visible` setting to allow status bar to be visible in fullscreen
Add `tablist.fullscreen_visible` setting to allow the tablist to be visible in fullscreen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides 2 settings
status_bar.fullscreen_visibleandtablist.fullscreen_visibleto allow the user to show/hide the status bar or tab list in fullscreen.Other userconf.lua solutions found in the wiki/issues for the status bar have not worked consistently, with the status bar showing in full screen at first and then disappearing.
This PR allows either bar to show in fullscreen consistently.
The default for both status bar and tablist remains as false.
The funtionality of
tablist.visibilityworks the same whentablist.fullscreen_visibleis used.