bump clickhouse and moka to remove dependency on thiserror 1 #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to fb5cef2 in 1 minute and 7 seconds. Click for details.
- Reviewed
706lines of code in12files - Skipped
0files when reviewing. - Skipped posting
7draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. app-server/src/ch/datapoints.rs:50
- Draft comment:
Consider handling serialization errors explicitly instead of using unwrap_or_default when converting datapoint payloads to string. This avoids silently masking potential issues. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. app-server/src/ch/evaluation_scores.rs:11
- Draft comment:
The custom serializer clones the timestamp; consider if borrowing (or avoiding clone) is possible to reduce overhead. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. app-server/src/ch/evaluation_scores.rs:50
- Draft comment:
Ensure that the lengths of 'points' and 'evaluation_datapoint_ids' match when zipping; otherwise, data might be silently dropped. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. app-server/src/ch/traces.rs:116
- Draft comment:
TraceAggregation::from_spans uses zip on spans and span_usage_vec; ensure these slices are aligned in order and length to avoid aggregation mismatches. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. app-server/src/ch/tags.rs:91
- Draft comment:
For batch tag insertion, new Uuid::new_v4() is called per tag. Confirm this is intended and that tag IDs don't need to be deterministic for duplicate checks. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. app-server/src/ch/spans.rs:123
- Draft comment:
Verify that sanitize_string properly handles all edge cases for converting input/output fields, as these fields are critical for span logging. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. app-server/src/ch/evaluation_datapoints.rs:65
- Draft comment:
When filtering out existing datapoints using dataset_link fields, ensure that missing links (default Uuid) are handled as intended and do not lead to accidental duplicate filtering. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_uUa3brC0jOn6u3f2
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Upgrade ClickHouse and Moka dependencies and migrate all ClickHouse insertions to the new typed, async insert API across CH modules.
clickhouseto0.14.1andmokato0.12.11inapp-server/Cargo.toml.thiserrordependency (remove explicit v1 pin); refreshCargo.lockwith new transitive crates (e.g.,clickhouse-macros,clickhouse-types) and removals tied to the upgrade.insert("table")with typedinsert::<Type>("table").awaitand adjust call sites in:app-server/src/ch/browser_events.rsapp-server/src/ch/datapoints.rsapp-server/src/ch/evaluation_datapoint_outputs.rsapp-server/src/ch/evaluation_datapoints.rsapp-server/src/ch/evaluation_scores.rsapp-server/src/ch/evaluator_scores.rsapp-server/src/ch/events.rsapp-server/src/ch/spans.rsapp-server/src/ch/tags.rsapp-server/src/ch/traces.rsWritten by Cursor Bugbot for commit fb5cef2. This will update automatically on new commits. Configure here.
Important
Update dependencies and modify Clickhouse insertions to use new API in multiple files.
clickhouseto0.14.1andmokato0.12.11inCargo.toml.thiserror 1.0.69inCargo.lock.insertcalls to specify type and use.awaitinbrowser_events.rs,datapoints.rs,evaluation_datapoint_outputs.rs.evaluation_datapoints.rs,evaluation_scores.rs,evaluator_scores.rs.events.rs,spans.rs,tags.rs,traces.rsfor consistency with newclickhouseAPI.This description was created by
for fb5cef2. You can customize this summary. It will automatically update as commits are pushed.