Bump some more deps, fix docker compose with wait for quickwit #1104
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 381bdf7 in 1 minute and 2 seconds. Click for details.
- Reviewed
957lines of code in16files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_6551F1AfUoCDkk5R
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
* feat: new spans visualization WIP * feat: small ui fixes * feat: update shared trace * feat: rename to reader * tmp * feat: move to sheet, deep parse json, fix comments * feat: address comments, sort on realtime insert, trace id timerange conditions * feat: adjust paddings on lists * feat: default to null if absent * feat: move button, full scroll * feat: small ui fixes * feat: fix layout * feat: move file * feat: rename hook to tsx
| } | ||
| timer.current = setTimeout(scheduleFetch, debounceMs); | ||
| } | ||
| }, [visibleSpanIds, scheduleFetch, debounceMs]); |
There was a problem hiding this comment.
Bug: Missing timer cleanup on component unmount
The useEffect that sets timer.current via setTimeout does not return a cleanup function to clear the timer when the component unmounts or when dependencies change. This can cause the scheduleFetch callback to execute after unmount, leading to React warnings about setting state on an unmounted component and unnecessary network requests. The codebase has a proper pattern for this in copy-tooltip.tsx that returns () => clearTimeout(timeoutRef.current) from the effect.
There was a problem hiding this comment.
@olzhik11 do you think that's true? If so, let's add a cleanup
* readme update * typo
| > | ||
| <ChartNoAxesGantt size={14} className="mr-1" /> | ||
| <span>Timeline</span> | ||
| </Button> |
There was a problem hiding this comment.
Shared trace view renders empty for unsupported persisted tabs
The tab state is now persisted to localStorage, but the shared trace view only renders content for tab === "tree" or tab === "timeline". If a user visits the main trace view and selects "reader", "chat", or "metadata" tab, that value gets persisted. When they later navigate to a shared/public trace, the persisted tab value is loaded but no content is rendered since the shared view doesn't handle those tab types. This results in an empty panel with no visible content.
Note
Introduces a new trace viewing experience and infrastructure updates, plus dependency and docs refresh.
Frontend (Trace UI)
Readerlist view with virtualized spans, minimap support, and a view selector dropdownPOST /api/projects/:projectId/traces/:traceId/spans/outputswith LRU cache, deep JSON parsing, and Quickwit-backed search URLsrouter.replace), and LLM/tool-call parsing improvementsApp server (Rust)
clickhouseto0.14.1and update inserts to typedinsert::<T>(...)withawait; disable client validation globally via.with_validation(false)mokato0.12.11; unifythiserrordependency; minor parsing fix for AI SDK tool calls (argsorinput)Docker Compose
quickwitservice with health checks; ensureapp-serverandfrontenddepends_onQuickwit in all compose filesDocs
Written by Cursor Bugbot for commit bdcb0d5. This will update automatically on new commits. Configure here.
Important
Update dependencies and Docker Compose configurations to include Quickwit service with health checks and ensure services wait for Quickwit to be healthy before starting.
clickhousefrom0.13.3to0.14.1inCargo.toml.mokafrom0.12.10to0.12.11inCargo.toml.thiserrorinCargo.lock.quickwitservice with health checks indocker-compose-full.yml,docker-compose-local-build.yml,docker-compose-local-dev.yml, anddocker-compose.yml.depends_onto includequickwitwithcondition: service_healthyforapp-serverandfrontendservices in all Docker Compose files.insertfunction calls to use type annotations andawaitinbrowser_events.rs,datapoints.rs,evaluation_datapoint_outputs.rs,evaluation_datapoints.rs,evaluation_scores.rs,evaluator_scores.rs,events.rs,spans.rs,tags.rs, andtraces.rs.This description was created by
for 381bdf7. You can customize this summary. It will automatically update as commits are pushed.