Price Floors: Fix TypeError when adUnit.bids is undefined #14360
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Use optional chaining to safely iterate over adUnit.bids since it can be undefined in some configurations. Fixes TypeError: Cannot read properties of undefined (reading 'forEach')
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeError in the priceFloors module that occurs when adUnit.bids is undefined. The error was thrown when updateAdUnitsForAuction attempted to iterate over bids without checking if the array exists.
Changes:
- Added optional chaining operator to safely handle undefined
adUnit.bidsin theupdateAdUnitsForAuctionfunction - Added a test case to verify the function doesn't throw when
adUnit.bidsis undefined
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/priceFloors.ts | Fixed TypeError by using optional chaining (?.) when accessing adUnit.bids |
| test/spec/modules/priceFloors_spec.js | Added test case to verify the fix handles undefined adUnit.bids correctly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
patmmccann
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
This PR fixes a TypeError that occurs in the priceFloors module when
adUnit.bidsis undefined.Error at updateAdUnitsForAuction
Other information
This PR solves #14359