Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

feat: allow request with x509 cert #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rockycookie wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: allow request with x509 cert #306

rockycookie wants to merge 3 commits into from

Conversation

@rockycookie
Copy link

@rockycookie rockycookie commented Jul 11, 2023 •
edited
Loading

Support x509 client cert auth with -cert and -cert-key; while I realized there has been a similar work done at #172 after I made this change lol

I would like to see either PR get merged; thx! I would like to merge this PR as I added unit test here lol

PerrySong
PerrySong approved these changes Jul 14, 2023
View reviewed changes
Copy link

@PerrySong PerrySong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, can you add unit tests for the change?

@rockycookie
Copy link
Author

rockycookie commented Jul 15, 2023 •
edited
Loading

Change LGTM, can you add unit tests for the change?

Cool, I will try to find some time next weekend to set up a (or two) unit test(s)~
btw, this code should be working; I have been running some simple load tests with certs with my local build~

added the unit test with self signed client and server certificates at d8a7c57

@rockycookie
Copy link
Author

rockycookie commented Jul 19, 2023

Hi @rakyll , hope to get a review from you; thx!

@rockycookie rockycookie force-pushed the support-cert branch 2 times, most recently from 96d6821 to 2386ee8 Compare August 9, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PerrySong PerrySong PerrySong approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rockycookie @PerrySong