Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

fix: correct randomness parameter in FRI Round 3 formula #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattvaux wants to merge 1 commit into from
Closed

fix: correct randomness parameter in FRI Round 3 formula #3615

mattvaux wants to merge 1 commit into from

Conversation

@mattvaux
Copy link

@mattvaux mattvaux commented Dec 20, 2025

Fixed typo in FRI protocol documentation where Round 3 formula used r_2 instead of r_3. The text correctly states r_3=64 is used, but the formula incorrectly referenced r_2. This ensures consistency with the pattern used in Rounds 1 and 2.

@mattvaux
fix: correct randomness parameter in FRI Round 3 formula
0e4dbed 
Fixed typo in FRI protocol documentation where Round 3 formula used r_2 instead of r_3. The text correctly states r_3=64 is used, but the formula incorrectly referenced r_2. This ensures consistency with the pattern used in Rounds 1 and 2.
@mattvaux mattvaux requested review from a team and pdg744 as code owners December 20, 2025 22:01
@vercel
Copy link

vercel bot commented Dec 20, 2025

@mattvaux is attempting to deploy a commit to the RISC Zero Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Dec 20, 2025

📝 Walkthrough

Walkthrough

Updates the randomness parameter in the Round 3 folding step from r_2 to r_3 in STARK proof documentation. The f_3(x) computation changes to use r_3 as the coefficient for the odd component instead of r_2.

Changes

Cohort / File(s) Summary
Documentation Update
website/docs/proof-system/stark-by-hand.md		 Swaps randomness index from r_2 to r_3 in Round 3 folding step; updates f_3(x) computation to use r_3 instead of r_2

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: correcting the randomness parameter from r_2 to r_3 in the FRI Round 3 formula, which is the primary fix in this documentation update.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific typo being fixed (r_2 to r_3 in Round 3 formula) and its context within the FRI protocol documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e73cb8 and 0e4dbed.

📒 Files selected for processing (1)
  • website/docs/proof-system/stark-by-hand.md (1 hunks)
🔇 Additional comments (1)
website/docs/proof-system/stark-by-hand.md (1)

321-321: Correct randomness parameter aligns with pattern and surrounding context.

The fix to use r_3 instead of r_2 in the Round 3 formula is appropriate. This maintains consistency with the pattern established in Rounds 1 and 2 (where Round i uses r_i), and aligns with the explicit statement on line 318 that r_3=64 is used, as well as the numerical calculation on line 325.

Comment @coderabbitai help to get the list of available commands and usage tips.

@flaub flaub closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdg744 pdg744 Awaiting requested review from pdg744 pdg744 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattvaux @flaub