Extend arrayvec 0.7 support to include ArrayString #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djkoloski
requested changes
Dec 23, 2025
| &self, | ||
| _deserializer: &mut D, | ||
| ) -> Result<ArrayString<CAP>, D::Error> { | ||
| Ok(ArrayString::from(self.as_str()).unwrap()) |
Collaborator
There was a problem hiding this comment.
I'd prefer to return an error instead of unwrapping here. See the docs for fail! for an example of how to write a rancor-compatible error.
Author
There was a problem hiding this comment.
It doesnt look like I can do that without changing the trait definition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the policy asking to avoid adding new crates.
Since this is adding support for more types in an already supported crate, I think its fine?
Implementation is taken from the smolstr_0_3 module.
The unwrap in deserialize looks a bit sus, but its the same behavior as the other types which just panic when they don't have enough room.