Modify ShutDownImminentException inheritance #2341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change ShutDownImminentException to inherit from BaseException instead of Exception.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2341 +/- ##
==========================================
- Coverage 93.61% 93.36% -0.26%
==========================================
Files 28 35 +7
Lines 3760 4627 +867
==========================================
+ Hits 3520 4320 +800
- Misses 240 307 +67 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change ShutDownImminentException to inherit from BaseException instead of Exception. Consider the difference:
If ShutDownImminentException is raised during
do_long_task(), then code will continue to execute which is against the spirit of ShutDownImminentException. It is semantically similar to something like a KeyboardInterupt, and so should be modelled like one.