ENH: Handle binary classifier in beeswarm plot #3981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3981 +/- ##
=======================================
Coverage 64.67% 64.67%
=======================================
Files 92 92
Lines 12862 12865 +3
=======================================
+ Hits 8318 8321 +3
Misses 4544 4544 ☔ View full report in Codecov by Sentry. |
CloseChoice
approved these changes
Feb 11, 2025
Collaborator
CloseChoice
left a comment
There was a problem hiding this comment.
Nice work. Thanks. LGTM
Collaborator
|
Regarding the assumption: [_, _, 2] is not always a binary classifier, it could also be a multi-output regression, though that is a rare case and probably just <3% of real-life cases. Since you added warning I would hope that our users understand if they went wrong and fix the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If the passed Explanation object has exactly two classes, assume it is a binary classifier and slice the second class.
Closes #3951
Related: #1460
Discussion
I've labelled this as an "enhancement" as I'm not sure the original behaviour is a bug, although that's debatable.
I'd value a review from @CloseChoice , in particular to get a sense of whether it's a reasonable assumption that an explanation with values of shape
[_, _, 2]represents a binary classifier.Checklist