Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Conversation

@Carlyle-Foster
Copy link
Contributor

@Carlyle-Foster Carlyle-Foster commented Apr 17, 2025

  • renamed predict_is_starting() to _predict because i find the former unintuitive
  • made _predict() return a TraversalId instead of &Traversal because most users were just taking the ID of the latter
  • this also made the lifetimes less restrictive so _predict() can now take self, and it's wrapper funcs (predict_starting & predict) no longer have duplicated destructuring code
  • match_term() has also been made to return an ID for the same reason, which also had a similar loosening effect on the lifetimes and allowed me to remove that inner function workaround
  • i also lifted a single line outside of the main match statement in earley(), making it a tad less verbose

...and that's about it for now

@coveralls
Copy link

coveralls commented Apr 17, 2025

Coverage Status

coverage: 97.13% (+0.02%) from 97.109%
when pulling 7aa14bb on Carlyle-Foster:main
into a8e52a3 on shnewto:main.

@CrockAgile
Copy link
Collaborator

nice cleanup, and even better explanations. merging 👍

@CrockAgile CrockAgile merged commit da120e4 into shnewto:main Apr 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants