refactor: replace kuchikiki with dom_query#1671
refactor: replace kuchikiki with dom_query#1671thomaseizinger wants to merge 13 commits intotauri-apps:devfrom
kuchikiki with dom_query#1671Conversation
|
I noticed that this code doesn't have any tests. Should we extract this into a non-Android gated module somewhere and write some tests that can run in CI? |
Package Changes Through 26079bdNo changes. Add a change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
thanks for the pr! much appreciated :)
Sounds reasonable but it wouldn't be a blocker for me |
Done! |
I don't want to break anything so I'll see to write a test for this. |
|
Never mind, its main branch moved to edition 2024 last month which requires a MSRV bump |
wouldn't be a blocker imo. we're getting closer to edition 2024 by the day |
|
I'd prefer merging something sooner and not blocking on an MSRV upgrade. Once the tests are in place, it should be easy to migrate though. |
a10128f to
1fa48b3
Compare
Legend-Master
left a comment
There was a problem hiding this comment.
Seems like the failed miri test is from servo/stylo#299
The
kuchikikidependency has not been actively maintained in a while and pulls in a lot of old dependencies. We can replace fairly easily with the more maintaineddom_querycrate.See tauri-apps/tauri#14958 for details.