Fix Example.java to match updated TDLib API#3588
Open
Eronary wants to merge 1 commit intotdlib:masterfrom
Open
Fix Example.java to match updated TDLib API#3588Eronary wants to merge 1 commit intotdlib:masterfrom
Eronary wants to merge 1 commit intotdlib:masterfrom
Conversation
Contributor
|
This has already been fixed in the private TDLib version, which will become publicly available with the upcoming Telegram update. |
Author
|
Can we merge these changes now so that the TDLib build passes successfully? When a new version of TDLib is released, my changes will be overwritten |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After recent TDLib API changes,
Example.javafails to compile with the following errors:Root cause
The
InlineKeyboardButtonconstructor was updated to include new parametersiconCustomEmojiId(long) andstyle(ButtonStyle), butExample.javawas not updated accordingly.Old signature:
New signature:
Additionally,
InlineKeyboardButtonTypeUrlnow requires an expliciturlparameter instead of being no-arg:Old:
new InlineKeyboardButtonTypeUrl()New:
new InlineKeyboardButtonTypeUrl(String url)Similarly,
SendMessageconstructor gained a newMessageTopic topicIdparameter:Old:
New:
Changes
example/java/org/drinkless/tdlib/example/Example.java— methodsendMessage:InlineKeyboardButton— added0foriconCustomEmojiIdandnullforstyle(default values, preserving existing behavior).InlineKeyboardButtonTypeUrl— now passes the URL string explicitly.SendMessage— addednullfor the newtopicIdparameter.