Open
Conversation
|
Tip Please add a changelog entry for this PR by clicking one of the links below. The changelog entry will be pre-filled with information from this PR. You can edit the title and description as needed before committing. You can also add a changelog entry manually by running 📝 Changelog Entries
📚 Documentation Preview✅ Docs preview is ready! 🔗 Preview Docs: https://tenzir-tenzir-preview-5503.surge.sh The preview will be updated automatically when you push new commits to this PR. |
c6a8f21 to
cfe4c41
Compare
a68e147 to
1658c75
Compare
Contributor
Author
|
Need to remember to revert #5504 |
There now is a new `convertible` overload for `concrete_type`s that infers the third "attribute" type argument. Additionally, these functions are now guarded against usage with types that are not `concrete_type`s.
1658c75 to
f32c716
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to fix an issue that recently became apparent with
tenzir.cache.capacity, where the default value is an "invalid"type (
unsigned long long) and hence the conversion would fail,even though it could be narrowed.
Investigating this revealed numerous issues in how
convertible,to, thetry_getfunctions were implemented/inter-dependent.Appearently in the release v5.14 -> v5.15 something changed in
the include order and the previously working setup broke.
Ideally we would entirely refactor
convertible&friends, butthat seems out of scope.