Closed
Conversation
std::endl is equivalent to outputing a newline followed by std::flush. But when writing to std::cerr (which is unbuffered) the flush is not needed and is just extra work for no gain - so change std::endl to '\n' in such cases.
The function itself returns void as does the function called in the retun statement, so there's no bug here, just a small passibility of confusion. When you return something you expect a value to be returned, which is not the case here, so just call the function and let that be it.
Const correctness makes code easier to reason about when reading it and (potentially) prevents accidental errors when modifying it in the future, so make a number of variables that are not modified const.
Owner
|
Thanks. |
Contributor
Author
|
Thank you for merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small fixes. Nothing super important. Feel free to just cherry-pick commits if you don't like all of them. Feedback is welcome if the commits are not wanted.
Kind regards,
Jesper Juhl