Converts simple rotation into a bespoke element #94582
Merged
+190
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacquerel
reviewed
Dec 22, 2025
Ghommie
reviewed
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Simple rotation components number in the 8-9k range per round, and each contains a needless callback datum as well.
These do not need to hold any state and can be bespoke elements, and the proc to do things post_rotation can just be a normal atom proc.
Still works as you'd expect, including items that have flag requirements like the wrench
Why It's Good For The Game
Makes a heavily used element much more lightweight, saves a few mb of memory.
Changelog
🆑
refactor: simple rotation component has been refactored into an element Please report any bugs to github.
/:cl: