Fix IntoResponse for tuples overriding error response codes
#3603
+479
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b3d548 to
a997c76
Compare
Turbo87
approved these changes
Jan 14, 2026
Collaborator
Turbo87
left a comment
There was a problem hiding this comment.
looks like CI is happy with it, so I guess it works well enough. the macro changes aren't particularly straight-forward to understand, but I'm not sure how to improve them either.
did you run the test suite with coverage tracking to see if we missed any edge cases?
Co-authored-by: David Pedersen <[email protected]> Co-authored-by: Yann Simon <[email protected]>
a997c76 to
b329274
Compare
Member
Author
|
I can generate a coverage report locally, but no clue how to view it.. Don't have time to set up continous coverage tracking right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2287.
Continuation of #2468.