sort: --files0-from should not panic when invalid utf-8 #9692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
140a726 to
e1837a0
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 18, 2025
57f5452 to
1c0f20e
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 19, 2025
Comment on lines
+1562
to
+1563
| let non_utf8_path = at.plus_as_string("").to_owned() + "/"; | ||
| let full_path = Path::new(&non_utf8_path).join(non_utf8_name); |
Contributor
There was a problem hiding this comment.
Unless I'm missing something, I think you can simplify it and use plus. And as a side effect it would also fix the clippy warning that's shown for line 1562.
Suggested change
| let non_utf8_path = at.plus_as_string("").to_owned() + "/"; | |
| let full_path = Path::new(&non_utf8_path).join(non_utf8_name); | |
| let full_path = at.plus(non_utf8_name); |
cakebaker
reviewed
Dec 19, 2025
| at.append("file2.txt", "apple\n"); | ||
|
|
||
| // Create a file with non-UTF-8 bytes in filename | ||
| let non_utf8_name = OsStr::from_bytes(b"\xff\xfefile3.txt"); |
Contributor
There was a problem hiding this comment.
I don't know if you have seen it: the spell checker complains about "xfefile" ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.