feat: Upload metrics and logs on proxy side #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds observability improvements to the proxy side by implementing metrics collection and logging for blob upload operations. The changes enhance monitoring capabilities and debugging by tracking upload success/failure rates and logging detailed upload events.
Key Changes:
- Added success and failure metrics counters for upload_blob and put_tag operations
- Introduced structured logging for blob upload attempts with digest and size information
- Refactored error handling in ReadWriteTransferer to use early returns for better readability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lib/dockerregistry/uploads.go | Added error and debug logging for blob upload operations with digest and size context |
| lib/dockerregistry/transfer/rw_transferer.go | Introduced success/failure metrics tracking for uploads, refactored error handling to early return pattern |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thijmv
approved these changes
Dec 18, 2025
Co-authored-by: Thijmen <[email protected]>
Co-authored-by: Thijmen <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds observability improvements to the proxy side by implementing metrics collection and logging for blob upload operations. The changes enhance monitoring capabilities and debugging by tracking upload success/failure rates and logging detailed upload events.
Key Changes: