Add set feature flag action to the admin panel #4448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aamederen
reviewed
Dec 26, 2025
aamederen
approved these changes
Dec 26, 2025
jeremyevans
approved these changes
Dec 29, 2025
Contributor
jeremyevans
left a comment
There was a problem hiding this comment.
I'm a little skeptical of accepting JSON via a text input, but without this, you are forced to use pry to do basically the same thing, so I think it makes sense to support this.
Currently, admin panel action forms only support text input fields. It's useful to support select input fields when there's a predefined set of options to choose from. If the value of an input is a hash instead of a string, each property of the hash is used separately.
This allows us to display custom error messages instead of generic internal server errors.
This new action allows feature flags to be set for projects directly from the admin panel. Since feature flags are predefined, a dropdown is used to select the flag. The value is optional, if no value is provided, it is treated as nil. The value is a JSON field, allowing it to be cast to a boolean, integer, float, array, or hash when possible.
795be0b to
58eb488
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow different input field types in the admin panel
Currently, admin panel action forms only support text input fields.
It's useful to support select input fields when there's a predefined set
of options to choose from.
If the value of an input is a hash instead of a string, each property of
the hash is used separately.
Handle CloverError exceptions in the admin panel
This allows us to display custom error messages instead of generic
internal server errors.
Add set feature flag action to the admin panel
This new action allows feature flags to be set for projects directly
from the admin panel.
Since feature flags are predefined, a dropdown is used to select the
flag.
The value is optional, if no value is provided, it is treated as nil.
The value is a JSON field, allowing it to be cast to a boolean, integer,
float, array, or hash when possible.