Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Comments

Remove deprecated protected getter methods from the decoration widgets#959

Merged
penguinolog merged 2 commits intourwid:masterfrom
penguinolog:deprecation_part3
Jan 1, 2025
Merged

Remove deprecated protected getter methods from the decoration widgets#959
penguinolog merged 2 commits intourwid:masterfrom
penguinolog:deprecation_part3

Conversation

@penguinolog
Copy link
Collaborator

  • WidgetDecoration._get_original_widget

  • WidgetDecoration._get_base_widget

  • Padding._get_align

  • Padding._get_width

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment
  • I've included docstrings and/or documentation and/or examples for my code (if this is a new feature)

* `WidgetDecoration._get_original_widget`
* `WidgetDecoration._get_base_widget`

* `Padding._get_align`
* `Padding._get_width`
@penguinolog penguinolog added the Breaking API breaking changes label Dec 3, 2024
@penguinolog penguinolog added this to the 3.0.0 milestone Dec 3, 2024
@penguinolog penguinolog requested a review from wardi December 3, 2024 17:16
@github-actions github-actions bot added the Widget label Dec 3, 2024
@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12544119594

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 74.303%

Totals Coverage Status
Change from base Build 12544096297: 0.03%
Covered Lines: 9298
Relevant Lines: 12566

💛 - Coveralls

@penguinolog penguinolog merged commit cf13256 into urwid:master Jan 1, 2025
19 checks passed
@penguinolog penguinolog deleted the deprecation_part3 branch January 1, 2025 12:42
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 11, 2025
Urwid 3.0.2
===========

2025-05-07

Bug fixes 🕷
++++++++++++
* Bugfix: Corner case: Scrollbar render for only 1 row height by @penguinolog in urwid/urwid#1021

Urwid 3.0.1
===========

2025-05-07

Bug fixes 🕷
++++++++++++
* Packaging: drop setup.py and adjust requirements by @penguinolog in urwid/urwid#1018
  Not updated `setup.py` lead to wrong metadata and mark of release 3.0.0 as Python 3.7 compatible.
  Since urwid is distribluted in the pre-packaged format (wheel),
  missing `setup.py` will not affect old toolchain users except special cases (manually enforced sdist usage).
* Python 3.14 compatibility: adjust `AsyncioEventLoop` by @penguinolog in urwid/urwid#1019

Urwid 3.0.0
===========

2025-05-06

Breaking Changes ⚠
++++++++++++++++++
* Drop deprecated `__super` property by @penguinolog in urwid/urwid#956
* Drop deprecated `FlowWidget`, `BoxWidget` and `FixedWidget` widgets by @penguinolog in urwid/urwid#955
* Remove deprecated protected getter methods from the `Canvas` and `AttrSpec` by @penguinolog in urwid/urwid#958
* Remove support for the `bytes` based fonts by @penguinolog in urwid/urwid#961
* Remove deprecated `TermScroller` by @penguinolog in urwid/urwid#960
* Remove deprecated protected getter methods from the decoration widgets by @penguinolog in urwid/urwid#959
* Remove deprecated protected getter methods from the container widgets by @penguinolog in urwid/urwid#957
* Remove deprecated protected setters in the decoration widgets by @penguinolog in urwid/urwid#968
* Remove deprecated protected methods from the container widgets by @penguinolog in urwid/urwid#970
* Remove deprecated protected method `_set_done` from the `ProgressBar` by @penguinolog in urwid/urwid#971

New features 🗹
+++++++++++++++
* API Extension: make `CommandMap` `MutableMapping` by @penguinolog in urwid/urwid#969
* Make sizing computation much faster for nested containers by @ogayot in urwid/urwid#991
* `MetaSignals` subclass `ABCMeta` by @penguinolog in urwid/urwid#962

Deprecations ⚡
+++++++++++++++
* `MetaSuper` should be the last base for classes by @penguinolog in urwid/urwid#972
* Announce deprecated API removal versions by @penguinolog in urwid/urwid#999

Bug fixes 🕷
++++++++++++
* Fix handling of WEIGHT selectable items in the `Pile` by @penguinolog in urwid/urwid#1006

Refactoring 🛠
++++++++++++++
* Refactoring: micro optimizations of iterable items reconstruction by @penguinolog in urwid/urwid#1009

New Contributors
++++++++++++++++
* @ogayot made their first contribution in urwid/urwid#991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking API breaking changes Widget

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants