chore: bump node version to lts#14026
Conversation
WalkthroughTwo Node.js version configurations updated: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.node-version (1)
1-1: Consider pinning to a specific LTS version instead of usinglts/*.Changing from
22.14.0tolts/*introduces automatic version drift:
- Different developers may end up with different Node.js versions over time
- The version will change when a new LTS is released, potentially causing unexpected behavior
- This conflicts with
netlify.tomlwhich pins to version 24Consider using a specific LTS version (e.g.,
lts/ironfor Node.js 20,lts/jodfor Node.js 22, or the version number directly) to ensure consistent environments across the team and CI/CD.Apply this diff to align with the Netlify configuration (assuming Node.js 24 is the intended version):
-lts/* +24Or use a specific LTS codename if available:
-lts/* +lts/[codename]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.node-version(1 hunks)netlify.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules
- GitHub Check: test / e2e-test
- GitHub Check: Header rules
- GitHub Check: Pages changed
🔇 Additional comments (1)
netlify.toml (1)
2-2: No issues found. Node.js 24 is LTS and version is consistent.Node.js 24 entered Active LTS on October 28, 2025, and
lts/*resolves to Node.js 24 (24.x). TheNODE_VERSION = "24"setting innetlify.tomlis consistent with thelts/*reference in.node-version—both point to the same LTS release. The PR successfully achieves its stated intent to bump to LTS.
|
Thanks. |
Summary by CodeRabbit