Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

Comments

Turbopack: cross-module constants#90300

Draft
mischnic wants to merge 4 commits intocanaryfrom
mischnic/cross-module-constants
Draft

Turbopack: cross-module constants#90300
mischnic wants to merge 4 commits intocanaryfrom
mischnic/cross-module-constants

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Feb 21, 2026

This is now a proper compile-time constant.

import { IS_DEV, SOME_VALUE } from './other.constants'
if (SOME_VALUE === 'x') { // statically evaluates to `true`
  console.log('x')
}
if (IS_DEV) { // statically evaluates to `true`
  console.log('dev')
}
// other.constants.ts
export const SOME_VALUE = 'x'

const node_env = process.env.NODE_ENV
const development_ent = 'development'
export const IS_DEV = node_env === development_ent

You can use code to compute constants just fine, and use any existing constants such as process.env.NODE_ENV. But no imports, and it fails when exporting a value that isn't constant.

Currently, it silently fails when importing a missing export. But I'd expect that to be covered by typechecking anyway, and detecting this would complicate the implementation quite a bit.

Problems:

  • how do we detect imports of constants modules. Right now, I just did request.includes(".constants")
  • this is similar in behavior to process.env.SOME_VALUE, but not exactly, because it's only constant for conditionals-evaluation, but the values isn't actually inlined for e.g. console.log(SOME_VALUE);
  • small: the error message for export is not a constant isn't very pretty

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Feb 21, 2026
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Comment on lines +168 to +169
println!("{} constant exports: {:#?}", path.path, exports);

Copy link
Contributor

@vercel vercel bot Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unconditional debug println! left in production code prints constant export info to stdout for every .constants module processed.

Fix on Vercel

@mischnic mischnic force-pushed the mischnic/cross-module-constants branch from 89cc65e to 24998d4 Compare February 21, 2026 14:04
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 21, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing mischnic/cross-module-constants (24998d4) with canary (ccee817)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@nextjs-bot
Copy link
Collaborator

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁█▁█▂
Cold (Ready in log) 445ms 446ms ▁█▁█▃
Cold (First Request) 899ms 902ms ▁█▄█▄
Warm (Listen) 455ms 456ms ▁█▁█▂
Warm (Ready in log) 445ms 443ms ▁█▁█▃
Warm (First Request) 361ms 355ms ▁█▁█▃
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁▁▁▁
Cold (Ready in log) 436ms 437ms ▁▃▁▁▃
Cold (First Request) 1.862s 1.852s ▁▁▁▁▃
Warm (Listen) 455ms 455ms ▁▁▁▁▁
Warm (Ready in log) 435ms 437ms ▁▂▁▁▂
Warm (First Request) 1.874s 1.874s ▁▁▁▁▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.041s 4.047s ▁█▁▇▅
Cached Build 4.089s 4.095s ▁█▁█▅
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.887s 13.907s ▁▁▁▁▄
Cached Build 14.012s 14.025s ▁▁▁▁▄
node_modules Size 474 MB 474 MB ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **399 kB** → **399 kB** ✅ -5 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 768 B 763 B
Total 768 B 763 B ✅ -5 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.48 kB N/A -
6280-HASH.js gzip 57.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 256 B 254 B
main-HASH.js gzip 39.1 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.53 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.49 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 58.3 kB -
Total 231 kB 232 kB ⚠️ +748 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.5 kB 2.5 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.97 kB ✅ -2 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 253 kB 253 kB
Total 377 kB 378 kB ⚠️ +258 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 614 B 613 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 43.8 kB 43.9 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 45.4 kB 45.5 kB ⚠️ +56 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 3.96 MB 3.97 MB 🔴 +10.4 kB (+0%)
index.pack gzip 104 kB 103 kB
index.pack.old gzip 102 kB 103 kB
Total 4.16 MB 4.17 MB ⚠️ +10.2 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 318 kB 318 kB
app-page-exp..prod.js gzip 168 kB 168 kB
app-page-tur...dev.js gzip 317 kB 317 kB
app-page-tur..prod.js gzip 168 kB 168 kB
app-page-tur...dev.js gzip 314 kB 314 kB
app-page-tur..prod.js gzip 166 kB 166 kB
app-page.run...dev.js gzip 314 kB 314 kB
app-page.run..prod.js gzip 167 kB 167 kB
app-route-ex...dev.js gzip 70.7 kB 70.7 kB
app-route-ex..prod.js gzip 49.1 kB 49.1 kB
app-route-tu...dev.js gzip 70.7 kB 70.7 kB
app-route-tu..prod.js gzip 49.2 kB 49.2 kB
app-route-tu...dev.js gzip 70.3 kB 70.3 kB
app-route-tu..prod.js gzip 48.9 kB 48.9 kB
app-route.ru...dev.js gzip 70.2 kB 70.2 kB
app-route.ru..prod.js gzip 48.9 kB 48.9 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB
pages-turbo....dev.js gzip 52.5 kB 52.5 kB
pages-turbo...prod.js gzip 38.5 kB 38.5 kB
pages.runtim...dev.js gzip 52.5 kB 52.5 kB
pages.runtim..prod.js gzip 38.4 kB 38.4 kB
server.runti..prod.js gzip 62 kB 62 kB
Total 2.81 MB 2.81 MB ✅ -1 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants