Conversation
|
The main point of the allocator, as for any region allocator, is to make many small, short-lived allocations fast by only performing a single more expensive allocation instead, so the comment about being pointless seems a bit odd? Two issues:
The plan was/is to eventually disallow storing anything from a |
It's well understood but the main point of region allocator is to reuse memory not give it back to parent allocator on each "reset" of the allocation state. That is what vibe.container's allocator does - it frees memory on deallocateAll and I believe this to be wrong as it misses then the 2nd major point in having region allocator. Pointless is probably too harsh a word for this.
I know, in fact I'd rather have vibe container implementation fixed. However, this was to show the gist of changes in one place instead of spreading it out in multiple PRs that have to be connected somehow.
This didn't occur to me. We could try per connection region allocator gated by this version then. Okay, I'll follow up with a PR to vibe.container and then rethink how allocator is used in this branch. |
|
Sorry for the late reaction, I missed the vibe-container PR in my notification feed and just stumbled over it now. BTW, there was a severe performance regression in vibe-core (vibe-d/vibe-core#441), so hopefully that also improves the baseline for the normal eventcore based implementation. |
|
Yes, I’ve seen that closure allocation but not enough know how in order to
fix it. This should make vibe.d-lite closer to the bare bones photon-http,
while being more featureful.
Вт, 21 окт. 2025 г. в 13:21, Sönke Ludwig ***@***.***>:
… *s-ludwig* left a comment (vibe-d/vibe-http#65)
<#65 (comment)>
Sorry for the late reaction, I missed the vibe-container PR in my
notification feed and just stumbled over it now. BTW, there was a severe
performance regression in vibe-core (vibe-d/vibe-core#441
<vibe-d/vibe-core#441>), so hopefully that also
improves the baseline for the normal eventcore based implementation.
—
Reply to this email directly, view it on GitHub
<#65 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACEZKWU2565IX5WPNXNKWD3YYCLXAVCNFSM6AAAAACHLQXVBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMRVHAZTCNRWHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Otherwise having a request allocator is pointless - it will go for the parent allocator on each request.
Feel free to use your allocator but it has to keep memory after deallocateAll unlike the current vibe.d container allocator does.