Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some extra attributes to cover the two implementations of dualprf metadata in Bureau radar volumes
From the rapic era, the following additional attributes are needed to define (1) the prf ratio and (2) which pulse has which prf (e.g, high PRF on odd pulses)
Specifically, these attributes are named:
Both return binary strings (e.g., rapic_UNFOLDING = b'2:3' rapic_HIPRF = b'ODDS')
Using these values it's possible to reconstruct the prt for each ray
For the modern area, only a single additional attribute is needed
This returns a numpy array of prt values (floats) for each ray.
These three attributes are extracted for each sweep alongside NI etc. The existing implementation works well for ignoring attributes which don't exist.
This will greatly help me improve the dual prf correction code implementation!