feat(types): accepts readonly arrays in props#4456
Open
pcorpet wants to merge 1 commit intoxyflow:mainfrom
Open
feat(types): accepts readonly arrays in props#4456pcorpet wants to merge 1 commit intoxyflow:mainfrom
pcorpet wants to merge 1 commit intoxyflow:mainfrom
Conversation
|
Member
|
Thanks for the PR! Unwanted mutations would be successfully prevented by this. However, we will have to check what implications this has in the grand scheme of things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library never modifies the arrays of nodes and edges given in properties, so we can accept readonly arrays.