feat(system): adds generic node/edge typings to xyhandle#5102
Open
thedanchez wants to merge 1 commit intoxyflow:mainfrom
Open
feat(system): adds generic node/edge typings to xyhandle#5102thedanchez wants to merge 1 commit intoxyflow:mainfrom
thedanchez wants to merge 1 commit intoxyflow:mainfrom
Conversation
|
e4c4184 to
046df33
Compare
046df33 to
8bac976
Compare
Member
|
Thanks for your PR! We will review it next week. |
Author
|
Hi @moklick -- curious if there are any thoughts on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds generic typings to
XYHandle.Comments
Let me know if this is undesirable. First time making a PR against the repository and not trying to introduce any breaking changes 🙂