Fix create_index operation column ordering
#1009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
create_indexoperation to take the columns on which the index should be defined as an list rather than a map.This ensures that the ordering of the columns in in the index is fixed to the same order as they appear in the migration file.
old format
new format
The changes in this PR are taken from reve-ai#5 🙏
We also modify the
pgroll updatecommand in this PR so that operations in the old format can be migrated to the new format (although for multi-column indexes the user will still have to ensure that the column order in the updated migration is what they expected).Fixes #1001