feat: Add traversal methods to Element#398
feat: Add traversal methods to Element#398KevinYeramian wants to merge 4 commits intoxmldom:masterfrom
Conversation
karfau
left a comment
There was a problem hiding this comment.
The method _insertBefore is calling the remove method but has extra code for joining inserting a child into the NodeList, can you please check if something also needs to be added there?
|
We also need some documentation:
|
|
Thank you a lot for the contribution so far. |
|
Review fixes committed!
|
Nice, loving it so far
Yeah, that comment is a bit hard to grasp, sorry.
Looks great for me. |
@KevinYeramian This comment points to my main concern for this PR so far. Do you still have capacity to continue working on it? I can help to relsove the conflicts if that's an issue for you. |
# Conflicts: # lib/dom.js # test/dom/element.test.js
|
I resolved the commit, which leads to failing tests (due to the breaking changes in version 9. |
What does this PR do?
ElementI used the word
traversalbecause it used in the official documentation to refers to these methods (link)