This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Upgrade to yrs 0.17.4 #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horusiath
suggested changes
Feb 6, 2024
Horusiath
left a comment
There was a problem hiding this comment.
Few changes proposed to reduce intermediate allocations when doing type conversions. Overall kudos: that's nice piece of good work 👍
| CompatiblePyType::String(s) => Ok(Any::String(s.extract::<String>()?.into_boxed_str())), | ||
| CompatiblePyType::String(s) => { | ||
| let string = s.extract::<String>()?; | ||
| let arc_str = Arc::from(string.as_str()); |
There was a problem hiding this comment.
If s.extract::<Arc<str>>() don't work, this could be Arc::from(string) directly.
| .map(|py_any| CompatiblePyType::try_from(py_any)?.try_into()) | ||
| .collect(); | ||
| result.map(|res| Any::Array(res.into_boxed_slice())) | ||
| result.map(|res| Any::Array(Arc::from(res.into_boxed_slice()))) |
There was a problem hiding this comment.
I'm not sure if .into_boxed_slice is needed. Possibly Arc::from(res) or Arc::from(res.as_slice()) could work as well without intermediate allocations.
|
Most probably superseded by #156 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.