Response json inconsistency between 404 & 500 #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snimavat
commented
Jul 3, 2025
| } | ||
|
|
||
| //FIXME @SUD - 404 doesnot return our standard json response | ||
| //currently its being handled by spring's "BasicErrorController" |
Contributor
Author
There was a problem hiding this comment.
@basejump The ignored test is the test, i added, to bring forward the issue of inconsistency in response format. kept it ignored because it fails but should pass just like it does for 500 case below
here, the "404" is handled by BasicErrorController so returns response format is different thn "500"
which is rendered by error.hbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.