Add cancel button for each of the ongoing docset downloads#1027
Add cancel button for each of the ongoing docset downloads#1027nishanthkarthik wants to merge 3 commits intozealdocs:mainfrom
Conversation
|
This fixes #712 |
9bad0d0 to
bfe266c
Compare
|
Thanks for the contribution! After a quick test I've noticed that the Cancel button stays visible during installation stage, but does not do anything. There are two options here: a) hide the button, b) make cancellation work for installation. The second requires more work, and should be submitted as a separate PR first. |
|
It's been a while, and sorry for ignoring this for so long. I believe this should go in, and can be polished later. The base branch has changed a lot, and some files do not even exist any more. Rebasing is pretty much impossible, but copied changes seem to work as expected. Let me know if you want to update the PR yourself, otherwise I'll push my version (with attribution) in a couple of days. |
2a3b442 to
72c73b0
Compare
|
I've force-pushed the original changes without the insanity of merge commits. |
Preview
The
Cancelbutton cancels the current download by emitting acancelButtonClickedsignal. This signal is emitted by overridingQStyledItemDelegate::editorEventand checking if theQMouseEventcoordinates fall inside the cancel button bounds