Only send missingmotd to connected client if not connected #1403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1403 +/- ##
==========================================
- Coverage 40.94% 40.92% -0.03%
==========================================
Files 109 109
Lines 21785 21786 +1
==========================================
- Hits 8919 8915 -4
- Misses 12866 12871 +5
Continue to review full report at Codecov.
|
DarthGandalf
approved these changes
Apr 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carrying on from the discussion from #1399 (comment) this pull request changes the missing motd so that it will only send no MOTD to the connecting client and not all other clients during a connection.
We will also not send the MOTD to the client if we're registered with an IRC server, because the underlying IRC server should have set an MOTD. Perhaps this isn't the expected behaviour if this module intends to work around broken IRC servers/clients. This is to prevent sending duplicate MOTD to the client (from missing motd module and form IRC server).