Fix build with SWIG 4.4 #1986
Closed
Fix build with SWIG 4.4 #1986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarthGandalf
reviewed
Dec 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1986 +/- ##
==========================================
- Coverage 50.91% 50.88% -0.03%
==========================================
Files 140 140
Lines 30381 30383 +2
Branches 4105 4105
==========================================
- Hits 15467 15460 -7
- Misses 14913 14922 +9
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SWIG 4.4 has dropped the usage of SWIG_NULLPTR again, which means we can't rely on its presence to identify SWIG >= 4.2.0 Generate a swig_version.h by parsing the output of `swig -version` and writing this in a hex representation Fixes znc#1979
Contributor
Author
|
Comments addressed; |
Member
|
Thanks, applied it to 1.10 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIG 4.4 has dropped the usage of SWIG_NULLPTR again, which means we can't
rely on its presence to identify SWIG >= 4.2.0
Generate a swig_version.h which parses the output of
swig -versionandwrites this in a hex representation, then compare on this
Fixes #1979