Improve: don't freeze Mudlet when copying large profile#5056
Improve: don't freeze Mudlet when copying large profile#5056vadi2 merged 14 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
What's with the "Check improvements with Mudlet's C++style guide / clang-tidy (pull_request_target)" failure - something is screwy with the update/ports of Hunspell - but just for that job...? 😵 |
|
Not sure. |
Co-authored-by: Stephen Lyons <[email protected]>
|
PR updated. |
| valid = false; | ||
| } | ||
|
|
||
| if (url.indexOf(QRegularExpression(qsl("^(([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])\\.){3}([0-9]|[1-9][0-9]|1[0-9]{2}|2[0-4][0-9]|25[0-5])$")), 0) != -1) { |
There was a problem hiding this comment.
🤔 This is something for another PR but this won't handle IPv:six: addresses... issue raised as #6065.
SlySven
left a comment
There was a problem hiding this comment.
I haven't physically tested this - I've only reviewed the code - as I see it the UI team still need to okay it so I'm leaving that aspect to them... 🙈
Brief overview of PR changes/additions
Don't freeze Mudlet when copying large profile
Motivation for adding to Mudlet
Better user experience for long-time players with large profiles. It'll also help people not think Mudlet has crashed if it's been copying for too long.
Other info (issues closed, discussion etc)
Fix #1980, fix #487
Release post highlight
Improved: copying large profiles will no longer freeze Mudlet up.