fix: get tempComplexRegexTrigger multiline to work#5946
Merged
vadi2 merged 2 commits intoMudlet:developmentfrom Feb 11, 2022
Merged
fix: get tempComplexRegexTrigger multiline to work#5946vadi2 merged 2 commits intoMudlet:developmentfrom
vadi2 merged 2 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
keneanung
approved these changes
Feb 3, 2022
Member
keneanung
left a comment
There was a problem hiding this comment.
I looked into this as well and would have done a similar solution.
Just keep the scope on a single topic next time 😉
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vadi2
approved these changes
Feb 11, 2022
Member
vadi2
left a comment
There was a problem hiding this comment.
Confirmed 👍
Given how fragile this is, could you write some busted tests with your example?
Member
|
I believe you need to click 'Solve issue' in https://app.bountysource.com/issues/105127054-tempcomplexregextrigger-multiline-not-working now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Should solve the issue at https://app.bountysource.com/issues/105127054-tempcomplexregextrigger-multiline-not-working
Motivation for adding to Mudlet
fix #5854
Other info (issues closed, discussion etc)
There are still a lot of issues with tempComplexRegexTrigger as mentioned at #5749
Should solve the issue.
The code in the example wont work as there is no linedelta set.
this should work:
Release post highlight
fix: tempComplexRegexTrigger multiline should work again