Fix: stopSounds() for triggers#5977
Merged
vadi2 merged 26 commits intoMudlet:developmentfrom Feb 20, 2022
mpconley:trigger-sound-tmedia
Merged
Fix: stopSounds() for triggers#5977vadi2 merged 26 commits intoMudlet:developmentfrom mpconley:trigger-sound-tmedia
vadi2 merged 26 commits intoMudlet:developmentfrom
mpconley:trigger-sound-tmedia
Conversation
vadim's feedback for sound API
…udlet-development
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
SlySven
reviewed
Feb 16, 2022
Contributor
|
Verified on windows. |
vadi2
approved these changes
Feb 20, 2022
Member
vadi2
left a comment
There was a problem hiding this comment.
Nice on getting rid of old code :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Enables the
play soundfeature of triggers to use the Lua API so that sounds could be controlled via the API. Fixes a problem where stopSounds() is not working for sounds created with triggers, per an issue reported referenced below.Motivation for adding to Mudlet
Corrects oversight introduced in 4.15 and reduces code.
Other info (issues closed, discussion etc)
Resolves #5974.
-Tamarindo@StickMUD