Infrastructure: Update Windows CI zlib to 1.2.12#6027
Merged
vadi2 merged 1 commit intodevelopmentfrom Apr 2, 2022
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Member
Author
|
The Windows build failed due to: I'm guessing we're installing a Luarocks version too old there. I've fixed that for Ubuntu builds, but not for Windows as well - that'll be a separate fix from this. |
demonnic
approved these changes
Apr 2, 2022
vadi2
added a commit
that referenced
this pull request
Apr 2, 2022
#### Brief overview of PR changes/additions Install Luarocks 3.8.0 to compile with Github's security policy. #### Motivation for adding to Mudlet CI builds on Windows work again. #### Other info (issues closed, discussion etc) #6013 fixed it for Ubuntu builds, this fixes it for Windows builds. Requires #6027 to be merged first in order to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Update Windows CI zlib to 1.2.12
Motivation for adding to Mudlet
So Windows CI builds work
Other info (issues closed, discussion etc)
zlib takes down old releases which is a somewhat hostile move -