Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve: Busted installation instructions on Windows#6057

Merged
vadi2 merged 4 commits intoMudlet:developmentfrom
RollanzMushing:WinTestingInstr
Apr 20, 2022
Merged

Improve: Busted installation instructions on Windows#6057
vadi2 merged 4 commits intoMudlet:developmentfrom
RollanzMushing:WinTestingInstr

Conversation

@RollanzMushing
Copy link
Contributor

Brief overview of PR changes/additions

  • added instructions to install LuaRocks and Busted to be compatible with Mudlet
  • added instructions to work around the package pathing problem

Motivation for adding to Mudlet

  • getting Busted to work with Mudlet on Windows is non-trivial
  • suggested by Vadi

@RollanzMushing RollanzMushing requested a review from a team April 10, 2022 08:56
@add-deployment-links
Copy link

add-deployment-links bot commented Apr 10, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Apr 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2022

Messages
✔️

PR type: Improvement

Generated by 🚫 dangerJS against 123662e

Copy link
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of these improvements?

RollanzMushing and others added 3 commits April 10, 2022 05:38
- Corrected description of message that would appear if LuaRocks is not in `Path`
@vadi2 vadi2 merged commit be69ea5 into Mudlet:development Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants