Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add: mudlet accessibility on alias for new profiles#6201

Merged
vadi2 merged 9 commits intodevelopmentfrom
enable-accessibility-package
Aug 4, 2022
Merged

Add: mudlet accessibility on alias for new profiles#6201
vadi2 merged 9 commits intodevelopmentfrom
enable-accessibility-package

Conversation

@vadi2
Copy link
Member

@vadi2 vadi2 commented Jul 31, 2022

Brief overview of PR changes/additions

mudlet accessibility on will toggle a few settings for a better visually impaired experience:

  • auto clear input line after sent text
  • disable showing sent text
  • hide blank lines (on windows)
  • offer workaround VoiceOver announce issue (on macOS)
  • set Ctrl+Tab as a shortcut to enable caret mode

Motivation for adding to Mudlet

So visually impaired players can just 1) download mudlet 2) run mudlet 3) use one alias to set all the options up

@add-deployment-links
Copy link

add-deployment-links bot commented Jul 31, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.17.0 milestone Jul 31, 2022
@Kebap
Copy link
Contributor

Kebap commented Aug 1, 2022

I really appreciate the command starting with the word Mudlet. You can add more other functionality that way later easily.

@vadi2
Copy link
Member Author

vadi2 commented Aug 1, 2022

image

None of other Mudlet aliases start with a prefix. Is that still okay?

@vadi2 vadi2 marked this pull request as ready for review August 1, 2022 17:44
@vadi2 vadi2 requested a review from a team August 1, 2022 17:44
@vadi2 vadi2 requested a review from a team as a code owner August 1, 2022 17:44
@vadi2 vadi2 requested a review from a team August 1, 2022 17:44
@demonnic
Copy link
Member

demonnic commented Aug 1, 2022

I think it's ok, delete old profiles is already pretty verbose, mudlet delete old profiles would be getting a bit much. Plus these have been established for a while now.

I do think it may be a good idea to try and keep the prefix in mind when making new aliases in future to include, though. In fact, that's the sort of thing where the alias could be one file and the function for parsing the alias could reside in LuaGlobal somewhere. Then updating to add more mudlet * aliases could just be a lua change, rather than even more preinstalled packages.

@Kebap
Copy link
Contributor

Kebap commented Aug 1, 2022

None of other Mudlet aliases start with a prefix. Is that still okay?

Good point, may want to deprecate those in due time.

Copy link
Member

@demonnic demonnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

clang-tidy review says "All clean, LGTM! 👍"

@vadi2 vadi2 merged commit cc4ee39 into development Aug 4, 2022
@vadi2 vadi2 deleted the enable-accessibility-package branch August 4, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants