improve Make timestamps persist between sessions#6355
Merged
SlySven merged 5 commits intoMudlet:developmentfrom Oct 24, 2022
Merged
improve Make timestamps persist between sessions#6355SlySven merged 5 commits intoMudlet:developmentfrom
SlySven merged 5 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Delwing
approved these changes
Oct 24, 2022
vadi2
pushed a commit
that referenced
this pull request
Nov 14, 2022
<!-- Keep the title short & concise so anyone non-technical can
understand it,
the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
File for persistent timestamps was being created every session because
of error console, so second session would come up with timestamps on.
Now only main console saves changes.
#### Motivation for adding to Mudlet
#### Other info (issues closed, discussion etc)
With #6355 I overlooked where consoles other than the main console would
enable timestamps and then they too would have it save to file. The
dlgTriggerEditor constructor was enabling timestamps on the error
console. So now I made it only save that when it is the main console.
I noticed that the error console is not currently showing timestamps,
but that'd be a separate issue. They show in PTB of Sep 1
`ptb-2022-09-01-42d5a` but stopped showing in PTB of Sep 2
`ptb-2022-09-02-e82a2`.
would fix #6408
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Logging stays on when you close and reopen, and now timestamps will do the same thing. Pretty much just duplicated the code and had it do the other thing.
Motivation for adding to Mudlet
Consistency between sessions
Other info (issues closed, discussion etc)
closes #5681