Fix: Use ccache for macOS Github CI builds#7459
Merged
vadi2 merged 3 commits intoMudlet:developmentfrom Oct 8, 2024
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Author
|
looks like ccache --show-stats -vv is not supported on ubuntu-20.04, so will revert that as it's not essential to the fix. |
Contributor
Author
|
Stats post fix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
This fixes #7150
Issue was that ccache was failing due to it's inability to guess the compiler by name on macOS.
Some details here: ccache/ccache#806
Solution was to set the CC/CXX environment variables explicitly and remove the path to ccache/libexec.
This change also updates CMake to 3.30.3 which is the most recent stable version packaged with Homebrew.
Added -vv to cmake --show-stats for more verbose cache stats in the post-build log.
Motivation for adding to Mudlet
Faster Github / CI builds!
Other info (issues closed, discussion etc)