Fix: Duplication of module contents after saving with module running on multiple loaded profiles#7572
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe. |
|
tested here with 8 profiles, 3 marked to sync on MULTIPLE AT ONCE....And I can no longer reproduce the issue!!! Thank you! Hopefully others can test as well and get the same result!! |
|
Module sync does indeed still work. I tested with 3 open profiles, each with 5 modules set to sync, and @techjoec tested with 8 open profiles (4 of which had sync enabled). Changes replicated across all profiles immediately, from any sync-enabled profile. |
|
Yes I tried a few different edits and configurations with 3 modules marked to sync on one and many profiles, sync seems to work fine (better, in fact). |
|
Reading that PR, I see folks mention nested images and files. I don't have any of that going on so perhaps someone else can test having assets included or such? My modules are .mpackages i exported from mudlet itself with just triggers/aliases/scripts within. |
Brief overview of PR changes/additions
Remove duplicate writes from reloadModule() function. The editing profile writes to the module (in saveProfile function), and then reloadModule uninstalls and reinstalls the module in all the other open profiles. Writing the module xml again in the other open profiles causes the duplication.
Motivation for adding to Mudlet
To fix the duplication bug in modules
Other info (issues closed, discussion etc)
Closes issue 7484
/claim #7484