move program* and recording* from libmythbase to libmythtv #1140
+838
−1,015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
536f939 to
ecbce1b
Compare
136d806 to
e549219
Compare
6c73c19 to
f6494da
Compare
f6494da to
b860a2a
Compare
b860a2a to
ede5052
Compare
ede5052 to
b67fad5
Compare
b67fad5 to
368a111
Compare
Contributor
Author
|
programinfo.h was missing the export header (transitively included from other files). |
All of the users of these functions already included remotefile.h.
The corresponding local implementations are already there and their only user already includes mythmiscutil.h.
It uses functions from StorageGroup, returns information about StorageGroups, and its users already include storagegroup.h
It is more similar to the functions already in libmythtv/tvremoteutil.* and its only user already includes libmythtv/tvremoteutil.h.
If desired it could be added back in libmythtv/tvremoteutil.*.
It is only used in relation to VideoScannerThread::SetHosts(), so move it there. The only other user already includes libmythmetadata/videoscan.h.
since the remaining functions all use ProgramInfo in some way.
which is its only user. This also was the only function in programinforemoteutil.h that was used by programinfo.cpp.
Also remove RemoteCheckForRecording(), which was only used by RemoteGetRecordingStatus().
since that is where related files and most of their uses are.
after splitting up libmythbase/remoteutil.h and moving program* and recording* from libmythbase to libmythtv.
368a111 to
592852a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, break up libmythbase/remoteutil.* so what remains can be moved to libmythtv.
Some unused function were also removed and some of them appear to be the only use of some SendReceiveStringList() commands. Should the corresponding code in mythbackend be removed?
Finally, move the program* and recording* files to libmythtv where related files and most uses of them are.
Checklist