Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix issue #1201 to allow very large descriptions in info by default #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
linuxdude42 merged 1 commit into from
Dec 20, 2025
Merged

Fix issue #1201 to allow very large descriptions in info by default #1206

linuxdude42 merged 1 commit into from
Dec 20, 2025
+2 −1

Conversation

@twitham1
Copy link
Contributor

@twitham1 twitham1 commented Nov 16, 2025

Thanks to @mosource21 for the bug report and @rcrdnalor for the fix!

Note that themes that have a copy of the programdetails block in their schedule-ui.xml may override this and still have the truncated descriptions bug. If so they will need the same fix.

Checklist

@twitham1
Fix issue MythTV#1201 to allow very large descriptions in info by def…
d247a43 
…ault

Thanks to @mosource21 for the bug report and @rcrdnalor for the fix!

Note that themes that have a copy of the programdetails block in their
schedule-ui.xml may override this and still have the truncated
descriptions bug.  If so they will need the same fix.
@twitham1 twitham1 mentioned this pull request Nov 16, 2025
Closed
@rcrdnalor
Copy link
Contributor

rcrdnalor commented Nov 17, 2025

On a recording that contains all possible information, all of these items
should be able to be displayed on one page without scrollbar:
See
File: mythfrontend/progdetails.cpp
Function: void ProgDetails::loadPage(void)

addItem(tr("Title"), ... ProgInfoList::kLevel1);
addItem(tr("Description"), s, ProgInfoList::kLevel1);
addItem(tr("Actors"), actors, ProgInfoList::kLevel1);
addItem(tr("Guest Star"), guestStars, ProgInfoList::kLevel1);
addItem(tr("Guest"), guests, ProgInfoList::kLevel1);
addItem(tr("Host"), hosts, ProgInfoList::kLevel1);
addItem(tr("Presenter"), presenters, ProgInfoList::kLevel1);
addItem(tr("Commentator"), commentators, ProgInfoList::kLevel1);
addItem(tr("Director"), directors, ProgInfoList::kLevel1);
addItem(tr("Category"), m_progInfo.GetCategory(), ProgInfoList::kLevel1);
addItem(tr("Genre"), s, ProgInfoList::kLevel1);
addItem(tr("Type", "category_type"), s, ProgInfoList::kLevel1);
addItem(tr("Season"), s, ProgInfoList::kLevel1);
addItem(tr("Episode"), s, ProgInfoList::kLevel1);
addItem(tr("Syndicated Episode Number"), syndicatedEpisodeNum, ProgInfoList::kLevel1);
addItem(tr("Original Airdate"), s, ProgInfoList::kLevel1);
addItem(tr("Program ID"), m_progInfo.GetProgramID(), ProgInfoList::kLevel1);
addItem(tr("Recording Rule"), recordingRule, ProgInfoList::kLevel1);
addItem(tr("Search Phrase"), searchPhrase, ProgInfoList::kLevel1);
addItem(tr("Recorded File Name"), recordedFilename, ProgInfoList::kLevel1);
addItem(tr("Recorded File Size"), recordedFileSize, ProgInfoList::kLevel1);
addItem(tr("Recording Group"), recordingGroup, ProgInfoList::kLevel1);

The current implementation is a valuable compromise to display all content on a single page.

@twitham1
Copy link
Contributor Author

twitham1 commented Nov 18, 2025

kLevel1 should be on one page for convenience to see it all without scrolling? Most of my TV show descriptions are just a line or few and so the description field has shrunk and all fields still fit on one page. This looks no different than before.

Only a few movies have descriptions long enough to cause a scroll bar for the last few fields. So this is also a good compromise with the advantage that you get the whole description. Those last few fields are less important to see anyway.

I thought perhaps we could invent a truncated shortDescription for kLevel1 while kLevel2 shows the original full description. But it doesn't work that way. kLevel2 shows all of kLevel1 so this would show both truncated and long description which would look redundant.

@linuxdude42 linuxdude42 merged commit ea3399d into MythTV:master Dec 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twitham1 @rcrdnalor @linuxdude42