Wrong integer numbers #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking good, will wait for all tests to pass |
|
This actually include the code tidying part and this Real number correction. Maybe I should close the code tidying PR #886? @sbryngelson |
|
yes indeed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 45.64% 45.76% +0.11%
==========================================
Files 68 68
Lines 18646 18668 +22
Branches 2249 2251 +2
==========================================
+ Hits 8511 8543 +32
+ Misses 8775 8767 -8
+ Partials 1360 1358 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@XZTian64 this looks good but i would like to also introduce a github action that checks to make sure no one introduces this kind of mistake again into the code. I was using src/post_process/m_derived_variables.fpp: q_sf(i, j, k) = 1e-16_wp
src/post_process/m_derived_variables.fpp: if (abs(top) < 1e-8_wp) top = 0._wp
src/post_process/m_derived_variables.fpp: if (abs(bottom) < 1e-8_wp) bottom = 0._wp
src/post_process/m_derived_variables.fpp: slope = (top*bottom)/(bottom**2._wp + 1e-16_wp)
src/post_process/m_derived_variables.fpp: q_sf(j, k, l) = max(0._wp, min(2._wp*slope, 5e-1_wp*(1._wp + slope), 2._wp))
src/post_process/m_derived_variables.fpp: q_sf(j, k, l) = (15e-1_wp*(slope**2._wp + slope))/(slope**2._wp + slope + 1._wp)
src/post_process/m_derived_variables.fpp: q_sf(j, k, l) = max(0._wp, min(15e-1_wp*slope, 1._wp), min(slope, 15e-1_wp))
src/post_process/m_data_output.fpp: H = ((gamma + 1_wp)*pres + pi_inf)/rho
src/post_process/m_data_output.fpp: if (Ma > MaxMa .and. (adv(1) > (1.0_wp - 1.0e-10_wp))) then
src/simulation/m_qbmm.fpp: if (abs(gam - 1._wp) <= 1.e-4_wp) then
src/simulation/m_compute_cbc.fpp: lambda_factor = (5e-1_wp - 5e-1_wp*sign(1._wp, lambda(1)))
src/simulation/m_compute_cbc.fpp: lambda_factor = (5e-1_wp - 5e-1_wp*sign(1._wp, lambda(2)))
src/simulation/m_compute_cbc.fpp: lambda_factor = (5e-1_wp - 5e-1_wp*sign(1._wp, lambda(3)))
src/simulation/m_sim_helpers.f90: E = gamma*pres + pi_inf + 5e-1_wp*rho*vel_sum + qv
src/simulation/m_hyperelastic.fpp: !if ( G <= verysmall ) G_K = 0_wp
src/simulation/m_bubbles_EE.fpp: 5e-1_wp/dx(j)*(q_prim_vf(contxe + idir)%sf(j + 1, k, l) - &
src/simulation/m_bubbles_EE.fpp: 5e-1_wp/dy(k)*(q_prim_vf(contxe + idir)%sf(j, k + 1, l) - &
src/simulation/m_bubbles_EE.fpp: 5e-1_wp/dz(l)*(q_prim_vf(contxe + idir)%sf(j, k, l + 1) - &
src/simulation/m_bubbles_EE.fpp: if (alf < 1.e-11_wp) then
src/simulation/m_rhs.fpp: 5e-1_wp/y_cc(k)*advected_qty_val*pressure_val*(flux_face1 + flux_face2)
src/simulation/m_rhs.fpp: 5e-1_wp/y_cc(k)*(flux_face1 + flux_face2)
src/simulation/m_rhs.fpp: 5e-1_wp/y_cc(q)*(flux_face1 + flux_face2)
src/simulation/m_rhs.fpp: rhs_vf(i)%sf(j, k, l) - 5e-1_wp/y_cc(k)* &
src/simulation/m_rhs.fpp: rhs_vf(i)%sf(j, k, l) - 5e-1_wp/y_cc(k)* &
src/simulation/m_rhs.fpp: rhs_vf(momxb + 1)%sf(j, k, l) + 5e-1_wp* &
src/simulation/m_rhs.fpp: rhs_vf(momxe)%sf(j, k, l) - 5e-1_wp* &
src/simulation/m_riemann_solvers.fpp: ! if ((G_L > 1e-3_wp) .and. (G_R > 1e-3_wp)) then
src/simulation/m_riemann_solvers.fpp: s_L = min(vel_L(dir_idx(1)) - sqrt(c_L*c_L + (4._wp*G_L/3_wp)/rho_L) &
src/simulation/m_riemann_solvers.fpp: , vel_R(dir_idx(1)) - sqrt(c_R*c_R + (4._wp*G_R/3_wp)/rho_R))
src/simulation/m_riemann_solvers.fpp: s_R = max(vel_R(dir_idx(1)) + sqrt(c_R*c_R + (4._wp*G_R/3_wp)/rho_R) &
src/simulation/m_riemann_solvers.fpp: , vel_L(dir_idx(1)) + sqrt(c_L*c_L + (4._wp*G_L/3_wp)/rho_L))
src/simulation/m_riemann_solvers.fpp: pres_SL = 5e-1_wp*(pres_L + pres_R + rho_avg*c_avg* &
src/simulation/m_riemann_solvers.fpp: Ms_L = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_L)/(1._wp + gamma_L))* &
src/simulation/m_riemann_solvers.fpp: Ms_R = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_R)/(1._wp + gamma_R))* &
src/simulation/m_riemann_solvers.fpp: s_S = 5e-1_wp*((vel_L(dir_idx(1)) + vel_R(dir_idx(1))) + &
src/simulation/m_riemann_solvers.fpp: xi_M = (5e-1_wp + sign(5e-1_wp, s_L)) &
src/simulation/m_riemann_solvers.fpp: + (5e-1_wp - sign(5e-1_wp, s_L)) &
src/simulation/m_riemann_solvers.fpp: *(5e-1_wp + sign(5e-1_wp, s_R))
src/simulation/m_riemann_solvers.fpp: xi_P = (5e-1_wp - sign(5e-1_wp, s_R)) &
src/simulation/m_riemann_solvers.fpp: + (5e-1_wp - sign(5e-1_wp, s_L)) &
src/simulation/m_riemann_solvers.fpp: *(5e-1_wp + sign(5e-1_wp, s_R))
src/simulation/m_riemann_solvers.fpp: E_L = gamma_L*pres_L + pi_inf_L + 5e-1_wp*rho_L*vel_L_rms + qv_L
src/simulation/m_riemann_solvers.fpp: E_R = gamma_R*pres_R + pi_inf_R + 5e-1_wp*rho_R*vel_R_rms + qv_R
src/simulation/m_riemann_solvers.fpp: (((4._wp*G_L)/3_wp) + tau_e_L(dir_idx_tau(1)))/rho_L), vel_R(dir_idx(1)) - sqrt(c_R*c_R + &
src/simulation/m_riemann_solvers.fpp: (((4._wp*G_R)/3_wp) + tau_e_R(dir_idx_tau(1)))/rho_R))
src/simulation/m_riemann_solvers.fpp: (((4._wp*G_R)/3_wp) + tau_e_R(dir_idx_tau(1)))/rho_R), vel_L(dir_idx(1)) + sqrt(c_L*c_L + &
src/simulation/m_riemann_solvers.fpp: (((4._wp*G_L)/3_wp) + tau_e_L(dir_idx_tau(1)))/rho_L))
src/simulation/m_riemann_solvers.fpp: pres_SL = 5e-1_wp*(pres_L + pres_R + rho_avg*c_avg* &
src/simulation/m_riemann_solvers.fpp: Ms_L = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_L)/(1._wp + gamma_L))* &
src/simulation/m_riemann_solvers.fpp: Ms_R = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_R)/(1._wp + gamma_R))* &
src/simulation/m_riemann_solvers.fpp: s_S = 5e-1_wp*((vel_L(dir_idx(1)) + vel_R(dir_idx(1))) + &
src/simulation/m_riemann_solvers.fpp: xi_M = (5e-1_wp + sign(0.5_wp, s_S))
src/simulation/m_riemann_solvers.fpp: xi_P = (5e-1_wp - sign(0.5_wp, s_S))
src/simulation/m_riemann_solvers.fpp: E_L = gamma_L*pres_L + pi_inf_L + 5e-1_wp*rho_L*vel_L_rms + qv_L
src/simulation/m_riemann_solvers.fpp: E_R = gamma_R*pres_R + pi_inf_R + 5e-1_wp*rho_R*vel_R_rms + qv_R
src/simulation/m_riemann_solvers.fpp: pres_SL = 5e-1_wp*(pres_L + pres_R + rho_avg*c_avg* &
src/simulation/m_riemann_solvers.fpp: Ms_L = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_L)/(1._wp + gamma_L))* &
src/simulation/m_riemann_solvers.fpp: Ms_R = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_R)/(1._wp + gamma_R))* &
src/simulation/m_riemann_solvers.fpp: s_S = 5e-1_wp*((vel_L(dir_idx(1)) + vel_R(dir_idx(1))) + &
src/simulation/m_riemann_solvers.fpp: xi_M = (5e-1_wp + sign(5e-1_wp, s_S))
src/simulation/m_riemann_solvers.fpp: xi_P = (5e-1_wp - sign(5e-1_wp, s_S))
src/simulation/m_riemann_solvers.fpp: E_L = gamma_L*pres_L + pi_inf_L + 5e-1_wp*rho_L*vel_L_rms
src/simulation/m_riemann_solvers.fpp: E_R = gamma_R*pres_R + pi_inf_R + 5e-1_wp*rho_R*vel_R_rms
src/simulation/m_riemann_solvers.fpp: rho_avg = 5e-1_wp*(rho_L + rho_R)
src/simulation/m_riemann_solvers.fpp: H_avg = 5e-1_wp*(H_L + H_R)
src/simulation/m_riemann_solvers.fpp: gamma_avg = 5e-1_wp*(gamma_L + gamma_R)
src/simulation/m_riemann_solvers.fpp: vel_avg_rms = vel_avg_rms + (5e-1_wp*(vel_L(i) + vel_R(i)))**2._wp
src/simulation/m_riemann_solvers.fpp: pres_SL = 5e-1_wp*(pres_L + pres_R + rho_avg*c_avg* &
src/simulation/m_riemann_solvers.fpp: Ms_L = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_L)/(1._wp + gamma_L))* &
src/simulation/m_riemann_solvers.fpp: Ms_R = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_R)/(1._wp + gamma_R))* &
src/simulation/m_riemann_solvers.fpp: s_S = 5e-1_wp*((vel_L(dir_idx(1)) + vel_R(dir_idx(1))) + &
src/simulation/m_riemann_solvers.fpp: xi_M = (5e-1_wp + sign(5e-1_wp, s_S))
src/simulation/m_riemann_solvers.fpp: xi_P = (5e-1_wp - sign(5e-1_wp, s_S))
src/simulation/m_riemann_solvers.fpp: (((4._wp*G_L)/3_wp) + tau_e_L(dir_idx_tau(1)))/rho_L), vel_R(dir_idx(1)) - sqrt(c_R*c_R + &
src/simulation/m_riemann_solvers.fpp: (((4._wp*G_R)/3_wp) + tau_e_R(dir_idx_tau(1)))/rho_R))
src/simulation/m_riemann_solvers.fpp: (((4._wp*G_R)/3_wp) + tau_e_R(dir_idx_tau(1)))/rho_R), vel_L(dir_idx(1)) + sqrt(c_L*c_L + &
src/simulation/m_riemann_solvers.fpp: (((4._wp*G_L)/3_wp) + tau_e_L(dir_idx_tau(1)))/rho_L))
src/simulation/m_riemann_solvers.fpp: pres_SL = 5e-1_wp*(pres_L + pres_R + rho_avg*c_avg* &
src/simulation/m_riemann_solvers.fpp: Ms_L = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_L)/(1._wp + gamma_L))* &
src/simulation/m_riemann_solvers.fpp: Ms_R = max(1._wp, sqrt(1._wp + ((5e-1_wp + gamma_R)/(1._wp + gamma_R))* &
src/simulation/m_riemann_solvers.fpp: s_S = 5e-1_wp*((vel_L(idx1) + vel_R(idx1)) + &
src/simulation/m_riemann_solvers.fpp: xi_M = (5e-1_wp + sign(5e-1_wp, s_S))
src/simulation/m_riemann_solvers.fpp: xi_P = (5e-1_wp - sign(5e-1_wp, s_S))
src/simulation/include/inline_riemann.fpp: rho_avg = 5e-1_wp*(rho_L + rho_R)
src/simulation/include/inline_riemann.fpp: vel_avg_rms = vel_avg_rms + (5e-1_wp*(vel_L(i) + vel_R(i)))**2._wp
src/simulation/include/inline_riemann.fpp: H_avg = 5e-1_wp*(H_L + H_R)
src/simulation/include/inline_riemann.fpp: gamma_avg = 5e-1_wp*(gamma_L + gamma_R)
src/simulation/include/inline_riemann.fpp: zcoef = min(1._wp, max(vel_L_rms**5e-1_wp/c_L, vel_R_rms**5e-1_wp/c_R))
src/simulation/include/inline_riemann.fpp: zcoef = min(1._wp, max(vel_L_rms**5e-1_wp/c_L, vel_R_rms**5e-1_wp/c_R))
src/simulation/include/inline_riemann.fpp: vel_L_tmp = 5e-1_wp*((vel_L(dir_idx(1)) + vel_R(dir_idx(1))) + zcoef*(vel_L(dir_idx(1)) - vel_R(dir_idx(1))))
src/simulation/include/inline_riemann.fpp: vel_R_tmp = 5e-1_wp*((vel_L(dir_idx(1)) + vel_R(dir_idx(1))) + zcoef*(vel_R(dir_idx(1)) - vel_L(dir_idx(1))))
src/simulation/m_data_output.fpp: Rc_min = 1e3_wp
src/simulation/m_bubbles.fpp: ! if max(d_1,d_2) < 1e-15_wp, h_size(2) = max(1e-6_wp, h0*1e-3_wp)
src/simulation/m_cbc.fpp: - 1e1_wp*ds(2) + 1e1_wp*ds(3) &
src/simulation/m_cbc.fpp: E = rho*e_mix + 5e-1_wp*rho*vel_K_sum
src/simulation/m_cbc.fpp: E = gamma*pres + pi_inf + 5e-1_wp*rho*vel_K_sum
src/simulation/m_cbc.fpp: dpres_dt = -5e-1_wp*(L(advxe) + L(1)) + rho*c*c*vel(dir_idx(1)) &
src/simulation/m_cbc.fpp: dpres_dt = -5e-1_wp*(L(advxe) + L(1))
src/simulation/m_cbc.fpp: + 5e-1_wp*drho_dt*vel_K_sum)
src/simulation/m_start_up.fpp: dyn_pres = dyn_pres + 5e-1_wp*v_vf(i)%sf(j, k, l)*v_vf(i)%sf(j, k, l) &
src/simulation/m_start_up.fpp: if (dt < 1e-3_wp*dt_init .and. cfl_adap_dt .and. proc_rank == 0) then
src/simulation/m_start_up.fpp: grind_time = time_final*1.0e9_wp/(sys_size*maxval((/1,m_glb/))*maxval((/1,n_glb/))*maxval((/1,p_glb/)))
src/simulation/m_ibm.fpp: if (dist(1, 1, 1) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(2, 1, 1) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(1, 2, 1) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(2, 2, 1) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: if (dist(1, 1, 1) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(2, 1, 1) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(1, 2, 1) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(2, 2, 1) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(1, 1, 2) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(2, 1, 2) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(1, 2, 2) <= 1e-16_wp) then
src/simulation/m_ibm.fpp: else if (dist(2, 2, 2) <= 1e-16_wp) then
src/simulation/m_acoustic_src.fpp: if (abs(sine_wave) < 1e-2_wp) then
src/simulation/m_acoustic_src.fpp: source = mag(ai)*sine_wave*1e2_wp
src/simulation/m_acoustic_src.fpp: real(wp), parameter :: threshold = 1e-10_wp
src/simulation/m_weno.fpp: - d_MD)*5e-1_wp
src/simulation/m_weno.fpp: - v_rs_ws(j, k, l, i))*5e-1_wp + beta_mp*d_LC
src/simulation/m_weno.fpp: + (sign(5e-1_wp, vL_min - vL_rs_vf(j, k, l, i)) &
src/simulation/m_weno.fpp: + sign(5e-1_wp, vL_max - vL_rs_vf(j, k, l, i))) &
src/simulation/m_weno.fpp: - d_MD)*5e-1_wp
src/simulation/m_weno.fpp: - v_rs_ws(j - 1, k, l, i))*5e-1_wp + beta_mp*d_LC
src/simulation/m_weno.fpp: + (sign(5e-1_wp, vR_min - vR_rs_vf(j, k, l, i)) &
src/simulation/m_weno.fpp: + sign(5e-1_wp, vR_max - vR_rs_vf(j, k, l, i))) &
src/simulation/m_pressure_relaxation.fpp: real(wp), parameter :: TOLERANCE = 1e-10_wp
src/simulation/m_pressure_relaxation.fpp: if (pres_K_init(i) <= -(1._wp - 1e-8_wp)*pres_inf(i) + 1e-8_wp) &
src/simulation/m_pressure_relaxation.fpp: pres_K_init(i) = -(1._wp - 1e-8_wp)*pres_inf(i) + 1e-8_wp
src/simulation/m_pressure_relaxation.fpp: f_pres = 1e-9_wp
src/simulation/m_pressure_relaxation.fpp: df_pres = 1e9_wp
src/simulation/m_pressure_relaxation.fpp: if (pres_relax <= -(1._wp - 1e-8_wp)*pres_inf(i) + 1e-8_wp) &
src/simulation/m_pressure_relaxation.fpp: pres_relax = -(1._wp - 1e-8_wp)*pres_inf(i) + 1._wp
src/simulation/m_pressure_relaxation.fpp: dyn_pres = dyn_pres + 5e-1_wp*q_cons_vf(i)%sf(j, k, l)* &
src/simulation/m_viscous.fpp: dqL_prim_dx_n(2)%vf(i)%sf(k, j, l) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqR_prim_dx_n(2)%vf(i)%sf(k, j, l) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqL_prim_dy_n(1)%vf(i)%sf(j, k, l) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqR_prim_dy_n(1)%vf(i)%sf(j, k, l) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqL_prim_dz_n(1)%vf(i)%sf(j, k, l) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqR_prim_dz_n(1)%vf(i)%sf(j, k, l) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqL_prim_dz_n(2)%vf(i)%sf(k, j, l) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqR_prim_dz_n(2)%vf(i)%sf(k, j, l) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqL_prim_dy_n(3)%vf(i)%sf(k, l, j) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqR_prim_dy_n(3)%vf(i)%sf(k, l, j) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqL_prim_dx_n(3)%vf(i)%sf(k, l, j) = 25e-2_wp* &
src/simulation/m_viscous.fpp: dqR_prim_dx_n(3)%vf(i)%sf(k, l, j) = 25e-2_wp* &
src/common/m_constants.fpp: real(wp), parameter :: dflt_real = -1e6_wp !< Default real value
src/common/m_constants.fpp: real(wp), parameter :: sgm_eps = 1e-16_wp !< Segmentation tolerance
src/common/m_constants.fpp: real(wp), parameter :: small_alf = 1e-11_wp !< Small alf tolerance
src/common/m_constants.fpp: real(wp), parameter :: verysmall = 1.e-12_wp !< Very small number
src/common/m_constants.fpp: real(wp), parameter :: initial_distance_buffer = 1e12_wp !< Initialized levelset distance for the shortest path pair algorithm
src/common/m_constants.fpp: real(wp), parameter :: dflt_adap_dt_tol = 1e-4_wp !< Default tolerance for adaptive step size
src/common/m_constants.fpp: real(wp), parameter :: threshold_first_guess = 1e-5_wp
src/common/m_constants.fpp: real(wp), parameter :: threshold_second_guess = 1e-15_wp
src/common/m_constants.fpp: real(wp), parameter :: scale_first_guess = 1e-3_wp
src/common/m_constants.fpp: real(wp), parameter :: scale_guess = 1e-2_wp
src/common/m_constants.fpp: real(wp), parameter :: small_guess = 1e-6_wp
src/common/m_helper_basic.f90: !! @param tol_input Relative error (default = 1e-10_wp).
src/common/m_helper_basic.f90: tol = 1e-10_wp
src/common/m_helper_basic.f90: !! @param tol_input Relative error (default = 1e-10_wp).
src/common/m_helper_basic.f90: tol = 1e-10_wp
src/common/m_helper.fpp: D_m = 0.242e-4_wp
src/common/m_variables_conversion.fpp: alpha_K = alpha_K/max(sum(alpha_K), 1e-16_wp)
src/common/m_variables_conversion.fpp: alpha_K = alpha_K/max(sum(alpha_K), 1e-16_wp)
src/common/m_variables_conversion.fpp: dyn_pres_K = dyn_pres_K + 5e-1_wp*qK_cons_vf(i)%sf(j, k, l) &
src/common/m_variables_conversion.fpp: E_K = rho_K*E_K + 5e-1_wp*rho_K*vel_K_sum
src/common/m_variables_conversion.fpp: + 5e-1_wp*rho_K*vel_K_sum + qv_K
src/common/m_phase_change.fpp: integer, parameter :: max_iter = 1e8_wp !< max # of iterations
src/common/m_phase_change.fpp: real(wp), parameter :: pCr = 4.94e7_wp !< Critical water pressure
src/common/m_phase_change.fpp: real(wp), parameter :: mixM = 1.0e-8_wp !< threshold for 'mixture cell'. If Y < mixM, phase change does not happen
src/common/m_phase_change.fpp: dynE = dynE + 5.0e-1_wp*q_cons_vf(i)%sf(j, k, l)**2/rho
src/common/m_phase_change.fpp: pS = 1.0e4_wp
src/common/m_phase_change.fpp: ! change this relative error metric. 1e4_wp is just arbitrary
src/common/m_phase_change.fpp: do while ((abs(pS - pO) > palpha_eps) .and. (abs((pS - pO)/pO) > palpha_eps/1e4_wp) .or. (ns == 0))
src/common/m_phase_change.fpp: Om = 1.0e-3_wp
src/common/m_phase_change.fpp: ((pS >= 0.0_wp) .and. (pS < 1.0e-1_wp))) then
src/common/m_phase_change.fpp: pS = 1.0e4_wp
src/common/m_phase_change.fpp: .and. ((sqrt(R2D(1)**2 + R2D(2)**2)/rhoe) > (ptgalpha_eps/1e6_wp))) &
src/common/m_phase_change.fpp: Om = 1.0e-3_wp
src/pre_process/m_assign_variables.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(j, k, l) = patch_id
src/pre_process/m_assign_variables.fpp: pres_mag = 1e-1_wp
src/pre_process/m_assign_variables.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(j, k, l) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, 0, 0) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, 0) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, 0) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, k) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, 0) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, k) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, 0) = patch_id
src/pre_process/m_patches.fpp: eta = 5e-1_wp + 5e-1_wp*tanh(smooth_coeff/min(dx, dy) &
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, 0) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, 0) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, 0, 0) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, 0) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, k) = patch_id
src/pre_process/m_patches.fpp: eps = 1.e-32_wp
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, k) = patch_id
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, k) = patch_id
src/pre_process/m_patches.fpp: eta = 5e-1_wp + 5e-1_wp*tanh(smooth_coeff/min(dx, dy, dz) &
src/pre_process/m_patches.fpp: if (1._wp - eta < 1e-16_wp) patch_id_fp(i, j, k) = patch_id
src/pre_process/m_patches.fpp: grid_mm(1, :) = (/minval(x_cc) - 0e5_wp*dx, maxval(x_cc) + 0e5_wp*dx/)
src/pre_process/m_patches.fpp: grid_mm(2, :) = (/minval(y_cc) - 0e5_wp*dy, maxval(y_cc) + 0e5_wp*dy/)
src/pre_process/m_patches.fpp: grid_mm(3, :) = (/minval(z_cc) - 0e5_wp*dz, maxval(z_cc) + 0e5_wp*dz/)
src/pre_process/m_model.fpp: dist_min = 1e12_wp
src/pre_process/m_model.fpp: dist_min_normal = 1e12_wp
src/pre_process/include/3dHardcodedIC.fpp: eps = 1e-9_wp
src/pre_process/include/3dHardcodedIC.fpp: pRef = 1.e5_wp
src/pre_process/include/3dHardcodedIC.fpp: alph = 5e-1_wp*(1._wp + tanh((y_cc(j) - intH)/2.5e-3_wp))
src/pre_process/include/2dHardcodedIC.fpp: eps = 1e-9_wp
src/pre_process/include/2dHardcodedIC.fpp: pRef = 1.e5_wp
src/pre_process/include/2dHardcodedIC.fpp: alph = 0.5_wp*(1._wp + tanh((y_cc(j) - intH)/2.5e-3_wp))
src/pre_process/include/2dHardcodedIC.fpp: q_prim_vf(contxb)%sf(i, j, 0) = 0.01_wp*factor + 1.e-4_wp*(1.0_wp - factor)
src/pre_process/include/2dHardcodedIC.fpp: q_prim_vf(E_idx)%sf(i, j, 0) = 1.0_wp*factor + 3.e-5_wp*(1.0_wp - factor)
src/pre_process/include/2dHardcodedIC.fpp: q_prim_vf(contxb)%sf(i, j, 0) = 1.e-4_wp
src/pre_process/include/2dHardcodedIC.fpp: q_prim_vf(E_idx)%sf(i, j, 0) = 3.e-5_wp
src/pre_process/m_grid.f90: x_cc(i) = x_domain%beg + 5e-1_wp*dx*real(2*i + 1, wp)
src/pre_process/m_grid.f90: y_cc(0) = y_domain%beg + 5e-1_wp*dy
src/pre_process/m_grid.f90: y_cc(i) = y_domain%beg + 5e-1_wp*dy*real(2*i + 1, wp)
src/pre_process/m_grid.f90: z_cc(i) = z_domain%beg + 5e-1_wp*dz*real(2*i + 1, wp)
src/pre_process/m_perturbation.fpp: ! IF ((perturb_alpha >= 25e-2_wp) .AND. (perturb_alpha <= 75e-2_wp)) THEN
src/pre_process/m_perturbation.fpp: if (abs(f0) <= 1e-10_wp) then
src/pre_process/m_perturbation.fpp: xcr((i - 1)*(nbp - 1) + k) = 5e-1_wp*(xbr((i - 1)*nbp + k) + xbr((i - 1)*nbp + k + 1))
src/pre_process/m_perturbation.fpp: xci((i - 1)*(nbp - 1) + k) = 5e-1_wp*(xbi((i - 1)*nbp + k) + xbi((i - 1)*nbp + k + 1)) |
sbryngelson
reviewed
Jun 16, 2025
prathi-wind
pushed a commit
to prathi-wind/MFC-prathi
that referenced
this pull request
Jul 13, 2025
Co-authored-by: Xuzheng Tian <[email protected]> Co-authored-by: Spencer Bryngelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looked through all numbers look like
1_wp. Made those to be1._wpin Real type calculation.Fixes #(issue) 885
Type of change
Please delete options that are not relevant.
Scope
If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Test Configuration:
Checklist
docs/)examples/that demonstrate my new feature performing as expected.They run to completion and demonstrate "interesting physics"
./mfc.sh formatbefore committing my codeIf your code changes any code source files (anything in
src/simulation)To make sure the code is performing as expected on GPU devices, I have:
nvtxranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR./mfc.sh run XXXX --gpu -t simulation --rsys --hip-trace, and have attached the output file and plain text results to this PR.