Add db export malware warning #10490
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove duplicate emailDstRule call for generic 'email' case - Prevents duplicate entries in NIDS export output - Generic email attributes now default to source rules only - Users can still use 'email-dst' for destination-specific rules - Fixes issue MISP#6565
…6565 Fix duplicate email rules in NIDS export
This PR adds a warning message to the database export functionality to inform users that malware samples are not included in database exports since they are stored on the filesystem rather than in the database. The warning message appears when users access the export function and helps set proper expectations about what will be included in the export. Fixes MISP#3101
Reverted NIDS email duplicate fix changes to keep this branch focused only on the database export malware warning feature. The NIDS fix will be implemented in a separate PR.
|
Hi @adulau, Thank you for the feedback. You're absolutely right - I understand now that each fix should be in its own separate branch with its own PR. I've just created separate branches for each fix:
I apologize for initially combining both changes in one PR. I'll make sure to follow the one-fix-per-PR approach going forward. Each branch now focuses on solving one specific issue with its own commit history. Thank you for your patience and guidance on the proper contribution process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a warning message to the database export functionality to inform users that malware samples are not included in database exports since they are stored on the filesystem rather than in the database.
Changes:
Fixes: #3101
Testing
Questions