Allow site admin to see authkey from other admins #9965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the fix from 8577790 by explicitly checking if the current user is not a site admin before redacting the authkey.
Member
|
Thanks, merged into develop, it will be in the next release. Good catch! |
Contributor
Author
Good to hear! Should we close this PR? Unsure how the git flow works for this project. |
Member
|
Hmm yeah, good question. I wonder why this wasn't auto-closed. Let's wait until the next release, maybe it wasn't merged in time for the last one! |
Contributor
Author
|
Can we close this PR @iglocska? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Improves the fix from 8577790 by explicitly checking if the current user is not a site admin before redacting the authkey.
Questions