Release 1.0.0 RC3 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DeminifyStackTrace perf improvements. * Make ToString() on a DeminifyStackTraceResult use fewer allocations. * Make ParseStackTrace use fewer allocations and have its result be immutable * Make most fields on FunctionMapEntry be read-only * Fix unit test warnings * Make FunctionMapEntry immutable * Make the SourcePosition class immutable * Fix build warnings * Make MappingEntry be a struct * Make binding information be a struct * Make sourcemap immutable * Additional clean-up * More clean-up. * Make more things read-only * Remove accidental Debugger.Launch() * Leave comment about why the FunctionMap is stored in descending order * Some more clean-up * fix typo * fix comment to remove reference to other project. * Rename GetDeminifiedMethodNameFromSourceMap --> GetDeminifiedMethodName in unit tests. * Add unit tests for new code. * Remove duplicate StringExtensions classes. (cherry picked from commit 38362c5ed160edae64296ab7d036fd0e779c2d27) # Conflicts: # src/SourceMapToolkit.CallstackDeminifier/DeminifyStackTraceResult.cs # src/SourceMapToolkit.CallstackDeminifier/FunctionFinderVisitor.cs # src/SourceMapToolkit.CallstackDeminifier/FunctionMapGenerator.cs # src/SourceMapToolkit.CallstackDeminifier/SourcemapToolkit.CallstackDeminifier.csproj # src/SourceMapTools/CallstackDeminifier/FunctionMapConsumer.cs # src/SourceMapTools/CallstackDeminifier/FunctionMapEntry.cs # src/SourceMapTools/CallstackDeminifier/FunctionMapStore.cs # src/SourceMapTools/CallstackDeminifier/IFunctionMapConsumer.cs # src/SourceMapTools/CallstackDeminifier/IFunctionMapGenerator.cs # src/SourceMapTools/CallstackDeminifier/IFunctionMapStore.cs # src/SourceMapTools/CallstackDeminifier/IStackTraceParser.cs # src/SourceMapTools/CallstackDeminifier/MethodNameStackFrameDeminifier.cs # src/SourceMapTools/CallstackDeminifier/SourceMapExtensions.cs # src/SourceMapTools/CallstackDeminifier/StackFrame.cs # src/SourceMapTools/CallstackDeminifier/StackFrameDeminifier.cs # src/SourceMapTools/CallstackDeminifier/StackTraceDeminifier.cs # src/SourceMapTools/CallstackDeminifier/StackTraceParser.cs # src/SourceMapTools/SourcemapParser/IReadOnlyListExtensions.cs # src/SourceMapTools/SourcemapParser/SourceMapGenerator.cs # src/SourceMapTools/SourcemapParser/StringExtensions.cs # src/SourcemapToolkit.SourcemapParser/MappingEntry.cs # src/SourcemapToolkit.SourcemapParser/MappingListParser.cs # src/SourcemapToolkit.SourcemapParser/Properties/AssemblyInfo.cs # src/SourcemapToolkit.SourcemapParser/SourceMap.cs # src/SourcemapToolkit.SourcemapParser/SourceMapParser.cs # src/SourcemapToolkit.SourcemapParser/SourceMapTransformer.cs # src/SourcemapToolkit.SourcemapParser/SourcePosition.cs # src/SourcemapToolkit.SourcemapParser/SourcemapToolkit.SourcemapParser.csproj # tests/SourcemapToolkit.CallstackDeminifier.UnitTests/FunctionMapConsumerUnitTests.cs # tests/SourcemapToolkit.CallstackDeminifier.UnitTests/FunctionMapGeneratorUnitTests.cs # tests/SourcemapToolkit.CallstackDeminifier.UnitTests/KeyValueCacheUnitTests.cs # tests/SourcemapToolkit.CallstackDeminifier.UnitTests/SourcemapToolkit.CallstackDeminifier.UnitTests.csproj # tests/SourcemapToolkit.CallstackDeminifier.UnitTests/StackFrameDeminifierUnitTests.cs # tests/SourcemapToolkit.CallstackDeminifier.UnitTests/StackTraceParserUnitTests.cs # tests/SourcemapToolkit.SourcemapParser.UnitTests/NumericMappingEntryUnitTests.cs # tests/SourcemapToolkit.SourcemapParser.UnitTests/SourceMapGeneratorUnitTests.cs # tests/SourcemapToolkit.SourcemapParser.UnitTests/SourceMapParserUnitTests.cs # tests/SourcemapToolkit.SourcemapParser.UnitTests/SourceMapTransformerUnitTests.cs # tests/SourcemapToolkit.SourcemapParser.UnitTests/SourceMapUnitTests.cs # tests/SourcemapToolkit.SourcemapParser.UnitTests/SourcePositionUnitTests.cs # tests/SourcemapToolkit.SourcemapParser.UnitTests/SourcemapToolkit.SourcemapParser.UnitTests.csproj # tests/SourcemapToolkit.SourcemapParser.UnitTests/UnitTestUtils.cs # tests/SourcemapTools.UnitTests/SourcemapParser/IReadOnlyListExtensionsUnitTests.cs # tests/SourcemapTools.UnitTests/SourcemapParser/StringExtensionsUnitTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.