Executing postponed calls does not require PanBounds #3123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Navigator class to remove the requirement for PanBounds when executing postponed calls during initialization. The key change is that postponed calls can now be executed as soon as the viewport has a size, rather than requiring both size and PanBounds to be set.
- Renamed initialization-related members to better reflect their purpose as "postponed calls"
- Modified the initialization logic to execute postponed calls when viewport has size, regardless of PanBounds
- Updated test cases to reflect the new behavior where extent changes are allowed without PanBounds
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Navigator.cs | Core refactoring to rename initialization concepts to postponed calls and remove PanBounds requirement |
| NavigatorTests.cs | Updated test cases and parameters to reflect new behavior allowing extent changes without PanBounds |
| SelectionStyleSample.cs | Fixed category classification from "White" to "Styles" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
If no PanBounds were set the Navigation methods were never executed.
The Solution
After this PR the postponed calls are executed as soon as the size is known.
If the PanBounds were set it will zoom to those at that point. If not then it will not change the Viewport, but HasExecutedPostponedCalls will be set to true so that subsequent calls will be executed right away.
Risks
This change opens up more scenarios and some may cause problems related to missing PanBounds or a resolution that is still zero.