Rework on sample interfaces #3151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reworks sample interfaces by migrating from IMapControlSample to ISample interface. The changes streamline the sample architecture by replacing the synchronous Setup method with an asynchronous CreateMapAsync method and eliminating direct dependency on IMapControl.
- Replaced
IMapControlSampleinterface withISampleinterface across multiple sample classes - Changed from synchronous
Setup(IMapControl)method to asynchronousCreateMapAsync()method - Removed direct
IMapControldependencies and updated refresh calls to use event parameters
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CustomStyleSample.cs | Updated interface and method signatures, reorganized field placement |
| RasterizingTileLayerWithThousandsOfPolygonsSample.cs | Migrated to ISample interface with async method pattern |
| RasterizingTileLayerGeoJsonSample.cs | Updated interface and reorganized imports |
| EditingSample.cs | Removed IMapControl field dependency and updated refresh calls to use event map reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer the simpler ISample interface over the IMapControlSample interface. In this PR I changed it in a few samples where this was immediately possible.
In others I will have to rewrite a bit more. I have an idea of how to do this in the editing samples. In the rasterization samples I would need to send the pixelDensity as part of FetchInfo.